Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors prompt-file slash command handling so both prompt generation (panel) and telemetry use a shared parser, while removing now-unneeded extension prompt-file lookup APIs from the custom-instructions service.
Changes:
- Moved prompt-file slash command ID derivation + parsing into
chatVariablesCollection.tsand updated panel prompt rendering to use it. - Updated panel request telemetry to derive slash command info from parsed prompt-file references and hash user-defined commands.
- Removed
getExtensionPromptFileInfoand narrowedgetExtensionSkillInfo’s public return type inICustomInstructionsService.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/platform/customInstructions/common/customInstructionsService.ts | Removes extension prompt-file info API and narrows extension skill info shape exposed by the interface. |
| src/extension/prompts/node/panel/test/chatVariablesHelpers.spec.ts | Updates tests to use shared slash command parsing utilities and adds coverage for parseSlashCommand. |
| src/extension/prompts/node/panel/chatVariables.tsx | Switches slash command user-message rewriting to the shared parseSlashCommand implementation. |
| src/extension/prompt/node/chatParticipantTelemetry.ts | Reworks slash command telemetry extraction to use prompt-file parsing + hashing logic. |
| src/extension/prompt/common/chatVariablesCollection.ts | Introduces shared prompt-file slash command ID + parsing helpers. |
DonJayamanne
previously approved these changes
Mar 28, 2026
zhichli
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.