Clean up a bit more legacy code around workspace chunk search#4795
Merged
mjbvz merged 2 commits intomicrosoft:mainfrom Mar 28, 2026
Merged
Clean up a bit more legacy code around workspace chunk search#4795mjbvz merged 2 commits intomicrosoft:mainfrom
mjbvz merged 2 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes legacy “strategy” abstractions around workspace chunk search, simplifying types and telemetry plumbing now that code search is the only supported retrieval path.
Changes:
- Removed
WorkspaceChunkSearchStrategyId/IWorkspaceChunkSearchStrategyand updated implementations/call sites accordingly. - Dropped
strategyfromWorkspaceChunkSearchResultand removed associated semantic search feedback/telemetry fields. - Simplified availability/indexing hooks by delegating availability to
CodeSearchChunkSearchand removing the auth-upgrade-triggered remote indexing path.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/platform/workspaceChunkSearch/node/workspaceChunkSearchService.ts | Removes legacy strategy plumbing and auth-upgrade indexing hook; updates search flow and telemetry. |
| src/platform/workspaceChunkSearch/node/embeddingsChunkSearch.ts | Removes implementation of the deleted strategy interface/id. |
| src/platform/workspaceChunkSearch/node/codeSearch/codeSearchChunkSearch.ts | Removes strategy interface/id usage and replaces local diff strategy id emission with a string. |
| src/platform/workspaceChunkSearch/common/workspaceChunkSearch.ts | Deletes strategy enum/interface types from the shared API surface. |
| src/extension/workspaceSemanticSearch/node/semanticSearchTextSearchProvider.ts | Removes strategy from feedback telemetry and GDPR schema. |
| src/extension/conversation/vscode-node/feedbackReporter.ts | Removes strategy from feedback telemetry event schema/payload. |
…vice.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bpasero
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.