src: add setTitle() as alternative to direct assignment#62804
src: add setTitle() as alternative to direct assignment#62804JonathanLopes404 wants to merge 3 commits intonodejs:mainfrom
Conversation
|
Review requested:
|
addaleax
left a comment
There was a problem hiding this comment.
Why does this introduce a new native method? Adding the new API is fine, but it should just trigger the same code paths.
|
@addaleax Updated in latest commit: setTitle now reuses the existing process.title path (removed native method). Could you please take another look? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62804 +/- ##
==========================================
+ Coverage 89.68% 89.70% +0.01%
==========================================
Files 706 706
Lines 218191 218237 +46
Branches 41746 41768 +22
==========================================
+ Hits 195691 195773 +82
+ Misses 14427 14373 -54
- Partials 8073 8091 +18
🚀 New features to boost your workflow:
|
|
Would add a reference on bottom of the |
Implement process.setTitle(title) as a new function-based API for setting the process title, complementing the existing process.title property assignment pattern Fixes: nodejs#62797 Signed-off-by: Jonathan Lopes <jonathan15989@protonmail.com>
Add process.setTitle(title) as a new API while reusing the existing process.title assignment behavior instead of introducing a separate native code path. Signed-off-by: Jonathan Lopes <jonathan15989@protonmail.com>
Add a cross-reference at the end of the process.title section to point to process.setTitle() as the new alternative API. Signed-off-by: Jonathan Lopes <jonathan15989@protonmail.com>
f0e771a to
685682f
Compare
|
I'm confused why an alias for Separately, is it expected that if i |
Implement process.setTitle(title) as a new function-based API for setting the process title, complementing the existing process.title property assignment pattern
Fixes: #62797