tests: reduce background task timing flakiness#37
Merged
dkundel-openai merged 1 commit intoopenai:mainfrom Mar 31, 2026
Merged
Conversation
dkundel-openai
approved these changes
Mar 31, 2026
trunkszi
pushed a commit
to trunkszi/codex-plugin-cc
that referenced
this pull request
Apr 5, 2026
Co-authored-by: VOIDXAI <VOIDXAI@users.noreply.github.com>
trunkszi
pushed a commit
to trunkszi/codex-plugin-cc
that referenced
this pull request
Apr 5, 2026
Co-authored-by: VOIDXAI <VOIDXAI@users.noreply.github.com>
trunkszi
added a commit
to trunkszi/codex-plugin-cc
that referenced
this pull request
Apr 16, 2026
Merges 13 new upstream commits (one was a squashed-duplicate of fork openai#37): - bc8fa66 avoid embedding large adversarial review diffs - d216a5f scope default cancel selection to current Claude session - 40d213d scope implicit resume-last selection to current Claude session - 4bd783b gracefully handle unsupported thread/name/set on older Codex CLI - dd335cb inherit process.env in app-server spawn when no explicit env is provided - 62c351a use app-server auth status for Codex readiness - f17e7f8 respect SHELL on Windows for Git Bash - 594fd1e fix working-tree review crash on untracked directories - c24afe8 honor --cwd when reporting session runtime - 8e9a38c correct invalid 'xhigh' reasoning effort in README - b115623 declare model in codex-rescue agent frontmatter - 6a5c2ba quote \$ARGUMENTS in cancel/result/status commands - 11a720b bump codex plugin version to 1.0.3 Conflict resolved in .claude-plugin/marketplace.json: keep fork-side description & version (1.2.0) that cover auggie + gemini plugins; accept upstream's per-plugin codex version bump to 1.0.3. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runtime.test.mjsWhy
Closes #33.
The background-task runtime tests are too timing-sensitive on slower machines. Normal startup variance can leave a job in
runninglong enough to fail assertions even when the implementation is correct.Validation
completedturnInterrupted: trueplus the recorded interrupt in the fake Codex state