fix: #2798 avoid stale hydrated input ids in server conversation tracker#2800
Merged
fix: #2798 avoid stale hydrated input ids in server conversation tracker#2800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes #2798 a resumed server-managed conversation bug where
OpenAIServerConversationTracker.hydrate_from_state()could recordid()values for reconstructed initial input items and later misclassify unrelated freshly allocated items as already sent. In the failure case, a newfunction_call_outputcould be dropped from the next payload, leading to"No tool output found for function call <call_id>."The change updates
src/agents/run_internal/oai_conversation.pyso hydrated initial input is deduplicated only through stable identifiers and content fingerprints, not Python object identity. It also adds regression coverage intests/test_server_conversation_tracker.pyfor both string and list initial inputs to lock in the resume behavior and prevent stale identity tracking from returning.