feat: support PUPPETEER_DANGEROUS_NO_SANDBOX environment variable#14756
Merged
zyzyzyryxy merged 2 commits intopuppeteer:mainfrom Mar 18, 2026
Merged
feat: support PUPPETEER_DANGEROUS_NO_SANDBOX environment variable#14756zyzyzyryxy merged 2 commits intopuppeteer:mainfrom
zyzyzyryxy merged 2 commits intopuppeteer:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
zyzyzyryxy
requested changes
Mar 11, 2026
Collaborator
zyzyzyryxy
left a comment
zyzyzyryxy
left a comment
There was a problem hiding this comment.
Looks good, just one change requested
Contributor
Author
|
@zyzyzyryxy Hi Piotr, just a gentle ping on this PR. The requested changes were addressed last week and all CI checks are green. Let me know if there's anything else needed before merging! |
zyzyzyryxy
approved these changes
Mar 18, 2026
Merged
Merged
4 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
PUPPETEER_DANGEROUS_NO_SANDBOXenvironment variable. When set, it automatically appends the--no-sandboxflag to the browser's launch default arguments, provided it hasn't already been passed manually by the user in theargsarray.This is particularly useful for Docker and CI environments where modifying the application code to pass
--no-sandboxto everypuppeteer.launch()invocation is not feasible or desirable.Fixes #5505