gh-113093: add parameter 'mode' in shelve.open#148662
Open
gmcrocetti wants to merge 1 commit intopython:mainfrom
Open
gh-113093: add parameter 'mode' in shelve.open#148662gmcrocetti wants to merge 1 commit intopython:mainfrom
gmcrocetti wants to merge 1 commit intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
gmcrocetti
force-pushed
the
gh-113093
branch
4 times, most recently
from
d3b2b7a to
ff64721
Compare
This comment has been minimized.
This comment has been minimized.
Member
|
Ok nvm the issue is #113093 |
picnixz
reviewed
Apr 19, 2026
| determine which accessed entries are mutable, nor which ones were actually | ||
| mutated). | ||
|
|
||
| The optional *mode* parameter controls the file mode (permissions) when creating |
Member
There was a problem hiding this comment.
Please update the signature of the function and only refers to the default of dbm.open()
| .. class:: DbfilenameShelf(filename, flag='c', protocol=None, \ | ||
| writeback=False, *, serializer=None, \ | ||
| deserializer=None) | ||
| writeback=False, mode=0o666, *, \ |
|
|
||
| Module :mod:`pickle` | ||
| Object serialization used by :mod:`!shelve`. | ||
|
|
| * Add support for custom serialization and deserialization functions | ||
| in the :mod:`shelve` module. | ||
| (Contributed by Furkan Onder in :gh:`99631`.) | ||
|
|
…ontrol file's type and access permissions
Contributor
Author
|
Hello @picnixz , thanks for the careful review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add parameter 'mode' in shelve.open, letting users control file's type and access permissions
issue #113093
📚 Documentation preview 📚: https://cpython-previews--148662.org.readthedocs.build/