Conversation
Lightning00Blade
approved these changes
Mar 2, 2026
Collaborator
Lightning00Blade
left a comment
Lightning00Blade
left a comment
There was a problem hiding this comment.
LGTM with comments
OrKoN
force-pushed
the
orkon/fix-emulation
branch
from
ac2c93c to
6f3e873
Compare
OrKoN
force-pushed
the
orkon/fix-emulation
branch
from
6f3e873 to
8906001
Compare
This was referenced Mar 2, 2026
OrKoN
pushed a commit
that referenced
this pull request
Mar 5, 2026
🤖 I have created a release *beep* *boop* --- ## [0.19.0](chrome-devtools-mcp-v0.18.1...chrome-devtools-mcp-v0.19.0) (2026-03-05) ### 🎉 Features * add pageId routing for parallel multi-agent workflows ([#1022](#1022)) ([caf601a](caf601a)), closes [#1019](#1019) * Add skill which helps with onboarding of the mcp server ([#1083](#1083)) ([7273f16](7273f16)) * integrate Lighthouse audits ([#831](#831)) ([dfdac26](dfdac26)) ### 🛠️ Fixes * improve error messages around --auto-connect ([#1075](#1075)) ([bcb852d](bcb852d)) * improve tool descriptions ([#965](#965)) ([bdbbc84](bdbbc84)) * repair broken markdown and extract snippets in a11y-debugging skill ([#1096](#1096)) ([adac7c5](adac7c5)) * simplify emulation and script tools ([#1073](#1073)) ([e51ba47](e51ba47)) * simplify focus state management ([#1063](#1063)) ([f763da2](f763da2)) * tweak lighthouse description ([#1112](#1112)) ([5538180](5538180)) ### 📄 Documentation * Adapt a11y skill to utilize Lighthouse ([#1054](#1054)) ([21634e6](21634e6)) * add feature release checklist to CONTRIBUTING.md ([#1118](#1118)) ([0378457](0378457)) * fix typo in README regarding slim mode ([#1093](#1093)) ([92f2c7b](92f2c7b)) ### 🏗️ Refactor * clean up more of the context getters ([#1062](#1062)) ([9628dab](9628dab)) * consistently use McpPage in tools ([#1057](#1057)) ([302e5a0](302e5a0)) * improve type safety for page scoped tools ([#1051](#1051)) ([5f694c6](5f694c6)) * make cdp resolvers use McpPage ([#1060](#1060)) ([d6c06c5](d6c06c5)) * move dialog handling to McpPage ([#1059](#1059)) ([40c241b](40c241b)) * move server to a separate file ([#1043](#1043)) ([a8bf3e5](a8bf3e5)) * remove page passing via context ([#1061](#1061)) ([4cb5a17](4cb5a17)) * set defaults to performance trace tool ([#1090](#1090)) ([dfa9b79](dfa9b79)) * simplify the response texts ([#1095](#1095)) ([cb0079e](cb0079e)) * type-cast as internal CdpPage interface ([#1064](#1064)) ([2d5e4fa](2d5e4fa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 1, 2026
## Summary - Add `@local/no-zod-nullable-object` ESLint rule that disallows `.nullable()` and `.object()` usage in tool schema files (`src/tools/**/*.ts`) - Fix the existing `zod.object()` violation in `fill_form` by converting the elements array from objects to `"uid=value"` formatted strings - Remove the TODO from CONTRIBUTING.md and link the rule name to the documented restriction ## Context Per the [PR #1073 review](#1073 (comment)) and the CONTRIBUTING.md guidelines, tool schemas should not use `.nullable()` or `.object()` types. Complex objects should be represented as short formatted strings instead. The rule catches: - `zod.object({...})` / `z.object({...})` - flags direct zod object schema usage - `.nullable()` - flags nullable schema usage on any expression Closes #1076 ## Test plan - [ ] `npx eslint src/tools/` passes with no violations - [ ] Creating a test file with `zod.object()` or `.nullable()` in `src/tools/` triggers the rule - [ ] TypeScript compilation passes (`npx tsc --noEmit`) - [ ] Existing `fill_form` test updated to use new string format --------- Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com> Co-authored-by: Alex Rudenko <OrKoN@users.noreply.github.com> Co-authored-by: Nikolay Vitkov <34244704+Lightning00Blade@users.noreply.github.com> Co-authored-by: Alex Rudenko <alexrudenko@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #918