Open
Conversation
In the page frame layout, the Edit button now appears before the Editors (edit access) selector. Previously, the order placed the Edit button after the Editors selector, separating it from the Add Widget button without a clear grouping rationale. The new order (Edit → Editors → Star → Add Widget) keeps editing-intent actions together. Both Edit and Editors now use tooltipProps for consistent tooltip behavior in the page frame path. Refs DE-1112 Co-Authored-By: Claude <noreply@anthropic.com>
…eEditButton Use the useHasPageFrameFeature hook directly in Controls instead of accepting it as a prop from detail.tsx. Remove the renderPageFrameEditButton helper and inline its JSX at the call site. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
…n bar Co-Authored-By: Claude <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
The EditAccessSelector component already has its own tooltip wrapper with conditional disabled logic. Wrapping it in an additional tooltip in the hasPageFrameFeature branch created nested tooltips that would both fire on hover, causing overlapping or flickering tooltip UI. Co-authored-by: Jonas <JonasBa@users.noreply.github.com>
Both branches of the hasPageFrameFeature ternary rendered identical EditAccessSelector components with the same props. Simplified by removing the unnecessary conditional and rendering the component directly. Co-authored-by: Jonas <JonasBa@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d8e9b29. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorder dashboard buttons in page-frame UI to
Star | Edit | Editors | Create Widget